Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [FilterBridge] Add URI/URL filter option to FilterBridge #3212

Merged
merged 1 commit into from
Jan 29, 2023
Merged

feat: [FilterBridge] Add URI/URL filter option to FilterBridge #3212

merged 1 commit into from
Jan 29, 2023

Conversation

jcgoette
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 10, 2023 •
edited
Loading

Pull request artifacts

file last change
FilterBridge-current-context1 2023-01-10, 05:53:08
FilterBridge-pr-context1 2023-01-10, 05:53:08

@dvikan
Copy link
Contributor

dvikan commented Jan 17, 2023

This is a good change. But I notice that the user input is not escaped for regex and I think it's intentional. This means that trying to filter on e.g. http://google.com would fail because / is used as delimiter. It also means the dot . in google.com can be any character.

@dvikan dvikan merged commit 69290c8 into RSS-Bridge:master Jan 29, 2023
@dvikan dvikan mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcgoette @dvikan